feat(core): keyboard navigation and focus shortcut for unified search#62157
Open
pringelmann wants to merge 1 commit into
Open
feat(core): keyboard navigation and focus shortcut for unified search#62157pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
pringelmann
added
accessibility
feature: search
team: IDP
pringelmann
force-pushed
the
feat/search-keyboard-nav
branch
from
2c9d44c to
a1ff563
Compare
pringelmann
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
pringelmann
force-pushed
the
feat/search-keyboard-nav
branch
from
a1ff563 to
decf927
Compare
Contributor
Author
|
Works in Orca, had to restart browser. Also tested NVDA on Windows. |
pringelmann
force-pushed
the
feat/search-keyboard-nav
branch
2 times, most recently
from
e20fdcc to
bcc4dc0
Compare
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
feat/search-keyboard-nav
branch
from
bcc4dc0 to
918c9fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the combobox keyboard model and a global focus shortcut to the new unified search.
Header input is a
combobox: up/down arrows move a highlighted result viaaria-activedescendant(focus stays in the input), Enter opens it, first result is auto-selected, and anaria-liveregion announces searching/result counts.Also added global focus shortcut ⌘/Ctrl+K.
Before:
After:
Not included
aria-selectedand dropping the result tab-stops need a small@nextcloud/vue(NcListItem) change, tracked as a follow-up for this subtask.Checklist
enhancement,3. to review, unified-search)AI (if applicable)